Re: [PATCH 9/9] commit-reach.h: add missing declarations (hdr-check)

From: Derrick Stolee <stolee@gmail.com>
Date: Sep 19, 2018, 23:38 UTC
Message-ID: <eb77d563-8b3e-9b00-59b8-b050e6378c69@gmail.com>
In-Reply-To: <089b2111-b7e9-6795-b04a-ed259f78796a@ramsayjones.plus.com>

On 9/18/2018 8:15 PM, Ramsay Jones wrote:

Show 19 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>   commit-reach.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/commit-reach.h b/commit-reach.h
> index 7d313e2975..f41d8f6ba3 100644
> --- a/commit-reach.h
> +++ b/commit-reach.h
> @@ -1,12 +1,13 @@
>   #ifndef __COMMIT_REACH_H__
>   #define __COMMIT_REACH_H__
>   
> +#include "commit.h"
>   #include "commit-slab.h"
>   
> -struct commit;
>   struct commit_list;
> -struct contains_cache;

Interesting that you needed all of commit.h here, and these 'struct commit' and 'struct contains_cache' were not enough. Was there a reason you needed the entire header file instead of just adding a missing struct declaration?

Show 6 quoted lines

>   struct ref_filter;
> +struct object_id;
> +struct object_array;
>   
>   struct commit_list *get_merge_bases_many(struct commit *one,
>   					 int n,

These look like standard inclusions. Thanks!