git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] gitweb: Further refactoring

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 6, 2006, 10:52 UTC
Message-ID
<eb4hkp$m0o$1@sea.gmane.org>
In-Reply-To
<7vmzai89o1.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> The earlier 9-series looked fine, so I intend to apply them all
> to "next".  However, they were all tab damaged and it was very
> painful to fix up the patch.

I'm sorry for that. As far as I checked, KNode (news reader which I used for sending 9-(micro)series) preserves tabs when attaching file inline. I guess that GMane news-to-mail gateway might munge whitespace. I won't use KNode to send patches, then.

By the way, can anyone tell me how to setup git-send-email to send email via GMail (authenticated SMTP, via STARTTLS/SSL, on ports 25 or 465 or 587)?

Show 5 quoted lines
> This series, PATCH 1/5 (6?) looks fine (it is a bugfix for
> git_diff_print), but among others, one of them had a seriously
> fishy preimage (e.g. as you can see in "next", I haven't
> accepted the function rename patch but 3/6 talks about
> format_mark_referencing), and at that point my patience ran out.

I _have_ notified that this 6-series is on top of previous series, namely '[PATCH 7/5] Merge changes in "split patch 1" series' patch.

But I try to redo not accepted changes on top of next, and put "gitweb: Great subroutines renaming" on top of series. (BTW. this is simple search'n'replace on subroutine names... well, perhaps after 1.4.2...).

[...]
> Please note that I am primarily concentrating on polishing what
> is in "master" to finish 1.4.2 for now, so I might have missed
> breakage in these gitweb patches that I queued for "next".

I'm trying to check my gitweb patches, by checking the output of all possible actions, althought I think it doesn't encompass all the cases...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Junio C Hamano
Message 12 of 12 in “gitweb: Further refactoring”
  1. 0/6 gitweb: Further refactoringJakub Narebski, Aug 6, 2006
  2. 1/6 gitweb: Refactor untabifying - converting tabs to spacesJakub Narebski, Aug 6, 2006
  3. Matthias LederhoferAug 6, 2006
  4. 2/6 gitweb: Simplify git_diff_printJakub Narebski, Aug 6, 2006
  5. Junio C HamanoAug 6, 2006
  6. Jakub NarebskiAug 6, 2006
  7. 3/6 gitweb: Remove unused parse_date invocation from git_shortlog_bodyJakub Narebski, Aug 6, 2006
  8. 4/6 gitweb: Make blob diff -p1 like commit diffJakub Narebski, Aug 6, 2006
  9. 5/6 gitweb: Refactor printing shortened title in git_shortlog_body and git_tags_bodyJakub Narebski, Aug 6, 2006
  10. 6/6 gitweb: Refactor git_history_bodyJakub Narebski, Aug 6, 2006
  11. Junio C HamanoAug 6, 2006
  12. Jakub NarebskiAug 6, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.