git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7502-commit.sh: test_must_fail doesn't work with inline environment variables

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jun 19, 2008, 20:39 UTC
Message-ID
<eL0AGIYbdnvG_hyKGyAA6ogzMbixNrhYwemCgYnHo-tYJkBD8ad0kQ@cipher.nrlssc.navy.mil>
In-Reply-To
<7vd4mduv3t.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
Show 11 quoted lines
> A Subshell?
> 
> @@ -212,6 +212,7 @@ test_expect_success 'do not fire
>  	# Must fail due to conflict
>  	test_must_fail git cherry-pick -n master &&
>  	echo "editor not started" >.git/result &&
> -	test_must_fail GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> +	( GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" && export GIT_EDITOR &&
> +	  test_must_fail git commit ) &&
>  	test "$(cat .git/result)" = "editor not started"
>  '
That works and it's better.
-brandon
Previous: Junio C Hamano
Message 8 of 8 in “t7502-commit.sh: test_must_fail doesn't work with inline environment variables”
  1. t7502-commit.sh: test_must_fail doesn't work with inline environment variablesBrandon Casey, Jun 19, 2008
  2. Mike HommeyJun 19, 2008
  3. Brandon CaseyJun 19, 2008
  4. Mike HommeyJun 19, 2008
  5. Brandon CaseyJun 19, 2008
  6. Brandon CaseyJun 19, 2008
  7. Junio C HamanoJun 19, 2008
  8. Brandon CaseyJun 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.