git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] bisect: clear flags in passed repository

From
René Scharfe <l.s.r@web.de>
Date
Oct 31, 2020, 12:31 UTC
Message-ID
<e9f1dbc1-065b-dcf7-efc1-7709681de5f1@web.de>
In-Reply-To
<f8cce944-a094-6097-39c3-904f52e4b9f6@web.de>

69d2cfe6e8 (bisect.c: remove the_repository reference, 2018-11-10) kept the implicit the_repository reference lurking in clear_commit_marks_all(). Replace it as well.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 bisect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.c b/bisect.c
index ee7f7bd017..453bf10a0c 100644
--- a/bisect.c
+++ b/bisect.c
@@ -1090,7 +1090,7 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		  nr), nr, steps_msg);
 	free(steps_msg);
 	/* Clean up objects used, as they will be reused. */
-	clear_commit_marks_all(the_repository, ALL_REV_FLAGS);
+	clear_commit_marks_all(r, ALL_REV_FLAGS);

 	return bisect_checkout(bisect_rev, no_checkout);
 }
--
2.29.2
Previous: René Scharfe
Message 2 of 2 in “object: allow clear_commit_marks_all() to handle any repo”
  1. 1/2 object: allow clear_commit_marks_all() to handle any repoRené Scharfe, Oct 31, 2020
  2. 2/2 bisect: clear flags in passed repositoryRené Scharfe, Oct 31, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.