Re: [PATCH v2 2/5] gitweb: fix generation of "gitweb.js"

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 1, 2025, 16:30 UTC
Message-ID: <e9ea3630-a831-dec5-e461-3f550ceb7ec3@gmx.de>
In-Reply-To: <20250331-b4-pks-collect-build-fixes-v2-2-6b06136808f3@pks.im>

Hi Patrick,

On Mon, 31 Mar 2025, Patrick Steinhardt wrote:

Show 11 quoted lines

> diff --git a/gitweb/Makefile b/gitweb/Makefile
> index d5748e93594..26a683d4421 100644
> --- a/gitweb/Makefile
> +++ b/gitweb/Makefile
> @@ -118,7 +118,7 @@ $(MAK_DIR_GITWEB)gitweb.cgi: $(MAK_DIR_GITWEB)gitweb.perl
>  $(MAK_DIR_GITWEB)static/gitweb.js: $(MAK_DIR_GITWEB)generate-gitweb-js.sh
>  $(MAK_DIR_GITWEB)static/gitweb.js: $(addprefix $(MAK_DIR_GITWEB),$(GITWEB_JSLIB_FILES))
>  	$(QUIET_GEN)$(RM) $@ $@+ && \
> -	$(MAK_DIR_GITWEB)generate-gitweb-js.sh $@+ $^ && \
> +	$(MAK_DIR_GITWEB)generate-gitweb-js.sh $@+ $(filter %.js,$^) && \
>  	mv $@+ $@

A safer way might be to use `$(filter-out %.sh,$^)` just in case the Javascript libraries might at some stage be renamed (I could imagine, for example, that someone aims for ideological purity and renames them to `*.cjs`).

Ciao, Johannes