git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] mergetool--lib: fix '--tool-help' to correctly show available tools

From
Philippe Blain <levraiphilippeblain@gmail.com>
Date
Jan 7, 2021, 00:32 UTC
Message-ID
<e9a1e45b-70b4-2478-1669-4308c5902c5b@gmail.com>
In-Reply-To
<xmqqeeixpsvo.fsf@gitster.c.googlers.com>
Le 2021-01-06 à 18:06, Junio C Hamano a écrit :
Show 18 quoted lines
> Philippe Blain <levraiphilippeblain@gmail.com> writes:
> 
>>> What was the symptom before the fix?  Is it just missing only some
>>> tools among 30?  Was there some pattern in names of missing one and
>>> the ones that still got output?  Or was it more like "we see nothing
>>> shown"?
>> ...
>> Note that 'vimdiff', 'nvimdiff3' (last variant for vimdiff),
>> 'bc' and 'bc4' (last variant for bc) are absent, and
>> all other tools that have no variants are absent as well.
> 
> Thanks, that is exactly the kind of "some pattern" I wanted to see
> us looking for, because I wonder if it is a more robust and cheaper
> (maintenance wise) approach to find one single tool that we support,
> which does not have, and which is unlikely to gain, any numbered
> variants.  If we can find such a tool, we can grep for its name in
> the output.
> 

Or, just choose a few tools, including some variants, and grep for those? This way we are not relying on a single tool being shown for the test to pas...

Previous: Junio C HamanoNext: Philippe Blain via GitGitGadget
Message 8 of 10 in “mergetool--lib: fix '--tool-help' to correctly show available tools”
  1. mergetool--lib: fix '--tool-help' to correctly show available toolsPhilippe Blain via GitGitGadget, Dec 28, 2020
  2. mergetool--lib: fix '--tool-help' to correctly show available toolsPhilippe Blain via GitGitGadget, Dec 28, 2020
  3. SZEDER GáborJan 6, 2021
  4. Philippe BlainJan 6, 2021
  5. Junio C HamanoJan 6, 2021
  6. Philippe BlainJan 6, 2021
  7. Junio C HamanoJan 6, 2021
  8. Philippe BlainJan 7, 2021
  9. mergetool--lib: fix '--tool-help' to correctly show available toolsPhilippe Blain via GitGitGadget, Jan 7, 2021
  10. Philippe BlainJan 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.