Re: [PATCH] gitweb.cgi: Teach tree->raw to not require the hash of the blob

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 12, 2006, 08:32 UTC
Message-ID: <e92c1e$lvk$1@sea.gmane.org>
In-Reply-To: <7v64i31h6f.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 10 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
>> Teach tree->raw to not require the hash of the blob, but to
>> figure it out from the file name.  This allows to externally
>> link to files into the repository, such that the hash is not
>> required.  I.e. the file obtained would be as of the HEAD
>> commit.
>>
>> In contrast tree->blob for binary files passes the hash, as
>> does tree->blob->plain for "text/*" files.

Show 11 quoted lines

> I think _allowing_ to accept filename not hash is a sane change,
> and would be useful if you want to allow linking to always the
> HEAD version from external sites, but I do not think listing the
> raw link in the tree view without the hash is a good idea.  It
> makes things quite confusing that "blob" link in its
> neighbourhood gives the blob from that specific version, but
> "raw" gives the version from HEAD, even when you are browsing
> something other than HEAD.
> 
> BTW, can somebody volunteer to be a gitweb/ "subsystem
> maintainer"?

I think the change to raw aka. blob_plain and not to plain is because in plain view you have this HEAD link which takes us to HEAD revision of the file (even if we are on different branch IIRC).

Workaround for either format is to remove 'h' (hash) parameter entirely, and put in 'hb' (hashbase aka headref aka branch) the branch name. Gitweb then shows the contents of latest version of the file.

BTW. sometimes you want to link to specific version of the file, and sometimes to newest. I think it would be best (if possible, feasible, and not too much resource consuming) that links from tree specified by hash be to specified by hash version of file, while links from tree specified by headref and name only would have links to latest version of the file.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git