Re: [PATCH 2, proof of concept] autoconf: Use %configure in git.spec, autoconf dependency only in rpm target
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jul 7, 2006, 20:06 UTC
- Message-ID
- <e8mesd$8ur$4@sea.gmane.org>
- In-Reply-To
- <1152159397.10415.29.camel@dv>
Pavel Roskin wrote:
Show 9 quoted lines
> On Tue, 2006-07-04 at 16:09 +0200, Jakub Narebski wrote: > >> +Patch0: git-add-autoconf-configure.patch.gz > > I don't think we need patches in git.spec.in. Let's leave it to the > actual distributions. If you have a problem with rpm, please submit the > autoconf support for now and the rest will be cleaned up eventually. > Besides, the "next" branch has different and potentially conflicting > changes to git.spec.in for Git.pm support.
First, it is proof of concept patch, the concept being having autoconf dependency _only_ in rpm target.
Second, it should be "Source1: autoconf-configure.tar.gz" or something like that. Using "Patch0:" was an ugly hack.
That to say RPM builders use "PatchN:" for patches which didn't made upstream; perhaps they make sources more compatibile with distribution RPM is prepared for.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git