Re: Strange date format in git-send-email

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 5, 2006, 09:00 UTC
Message-ID: <e8fv2o$khv$1@sea.gmane.org>
In-Reply-To: <200607050817.37366.martijn.kuipers@lx.it.pt>

Martijn Kuipers wrote:

Show 15 quoted lines

> My email is sorted by date and a number of email-patches list the date format 
> as unknown (in kmail, that is).
> 
> When checking the headers of these mails I see the following pattern:
> 
> Date: mer, 05 jui 2006 00:36:08 +0200
> X-Mailer: git-send-email 1.4.1
> 
> Date: wto, 20 cze 2006 17:59:19 +0200
> X-Mailer: git-send-email 1.3.0
> 
> Date: Tue, Mar 14 12:12:35 2006 -0500
> User-Agent: send_patch 0.1
> 
> Date: Tue Feb 7 18:21:02 2006 +0100

[...]

> Is this my problem (or kmail), or is there something funny with 
> git-send-email? I just don't git it.

Yes, there was a problem with git-sen-email, namely it used strftime to print "Date:" header, but strftime is locale specific setting $ENV{LC_ALL} = 'C' is not enought.

There were two patches on the list: one hacky adding setlocale call (not applied), second implementing rfc-822 date in Perl. Should be in current.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git