Re: [RFC/PATCH] consistently try VISUAL, EDITOR and vi in this order.

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 3, 2006, 09:24 UTC
Message-ID: <e8anmn$ufp$1@sea.gmane.org>
In-Reply-To: <7vmzbrv1yc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> git grep -e VISUAL -e EDITOR revealed this inconsistency.  All
> other commands seem to check VISUAL and then EDITOR as they should.
>

> +     my $editor = $ENV{VISUAL} || $ENV{EDITOR} || 'vi';
>       system($editor, $compose_filename);

Shouldn't we check if we are in visual (non CLI-only) environment, like X-Window, MS Windows or MacOS X, before trying to use VISUAL? How other parts solve it? </me checks> Ah, we use VISUAL unconditionally, at least in scripts...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git