Re: Allow git bisect to auto-skip
- From
- Stefan Haller <lists@haller-berlin.de>
- Date
- Mar 24, 2024, 10:16 UTC
- Message-ID
- <e896da79-c87b-4475-9890-10051d8ddf76@haller-berlin.de>
- In-Reply-To
- <xmqqle68x008.fsf@gitster.g>
On 23.03.24 19:43, Junio C Hamano wrote:
Show 19 quoted lines
> Stefan Haller <lists@haller-berlin.de> writes: > >> On 22.03.24 23:31, Junio C Hamano wrote: >>> It often is discovered that a commit >>> breaks bisection after the fact and it is not feasible to rebase >>> all the history after the commit. >> >> This reminds me of a similar problem with git blame, for which we have >> the blame.ignoreRevsFile config to work around it. Couldn't there be a >> similar mechanism for bisect, e.g. bisect.skipRevsFile? > > A Very good point. If a breakage of a commit is "this does not even > build" kind of breakage, such a mechanism would be an excellent fit. > > But if a breakage is "only this particular test fails and we know > the reason why it fails has nothing to do with the bug we are > chasing", then compiling such a fixed list of commits, or pointing > at such a list with a configuration variable, would not work very > well, I am afraid.
That's true, but the same can be said about blame.ignoreRevsFile. There may be commits that contain both uninteresting whitespace changes and real changes (not in a well-maintained project of course :-), so it wouldn't be a good idea to add those to blame.ignoreRevsFile. But that's not a reason not to offer the feature at all.
-Stefan