Re: Help for the git patch with "---"
- From
Philippe Blain <levraiphilippeblain@gmail.com>
- Date
- Feb 25, 2021, 13:22 UTC
- Message-ID
- <e87e2ad1-e133-54d3-3f3d-8602ac242f64@gmail.com>
- In-Reply-To
- <25082af3-e8fd-e9d6-e980-43871c5b4840@gmail.com>
Le 2021-02-25 à 08:14, Philippe Blain a écrit :
Show 5 quoted lines
> Hi Dyrone, > > [CC-ing the list] > > Le 2021-02-25 à 04:36, 滕龙 a écrit :
--snip--
Show 19 quoted lines
>> I decide to remove it from the PR. >> >> So, did I deal the right way this time? > > Well, if you are sending a subsequent version of your patch series, > this space is usually used to summarize in words what > has changed since the last version of the patch series. > For example, for your v4 you could have written: > > Changes since v3: > - Improved <that> following comment from <insert reviewer name> > - Reworded the commit message > - etc. > > This is a explained in the MyFirstContribution tutorial [1]. I would > encourage you to do that if your series needs a v5 (I haven't read it yet). > It's also a way to make sure that you modified your patch to account > for all feedback you got in earlier iterations. >
Another thing: GitGitGadget adds a "CC:" footer in the PR description with the email of every person that responds to your patch series on the mailing list. This is then used to CC these persons when sending further iterations of the series. So you should *not* remove these "CC:" footer when you update the PR description to summarize you changes for each new version.