git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] autoconf: Use autoconf to write installation directories to config.mak

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 1, 2006, 13:58 UTC
Message-ID
<e85v14$85c$1@sea.gmane.org>
In-Reply-To
<44A51693.5020501@op5.se>
Andreas Ericsson wrote:
Show 11 quoted lines
> This is bad, since it forces users to do one thing first and then do 
> what they're used to. Better to have the script add
> 
> -include config.mak.autogen
> 
> LAST in config.mak, unless it's already in the file and generate 
> config.mak.autogen with configure.
> 
> Since Make does things bottoms-up (much like swedish students and 
> midsummer celebrators), the previous hand-edited defaults in config.mak 
> will beat the ones in config.mak.autogen (a good thing).

That's not true, unless we use '?=' assignment in Makefile. And we _want_ to override defaults provided in main git Makefile, so in config.mak.autoconf, and probably in user's own config.mak we use '=' overriding assignment. So it would be better to just add "-include config.mak.autogen" to makefile before "-include config.mak", as in patch below.

diff --git a/Makefile b/Makefile
index ccd7c62..a37d400 100644
--- a/Makefile
+++ b/Makefile
@@ -333,6 +333,7 @@ ifneq (,$(findstring arm,$(uname_M)))
        ARM_SHA1 = YesPlease
 endif
 
+-include config.mak.autogen
 -include config.mak
 
 ifdef WITH_OWN_SUBPROCESS_PY

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Jakub NarebskiNext: Junio C Hamano
Message 26 of 30 in “autoconf: Use autoconf to write installation directories to config.mak”
  1. autoconf: Use autoconf to write installation directories to config.makJakub Narebski, Jun 29, 2006
  2. Uwe ZeisbergerJun 29, 2006
  3. autoconf: Use autoconf to check for libraries: openssl/crypto, curl, expatJakub Narebski, Jun 29, 2006
  4. autoconf: Use autoconf to check for some types and library functionsJakub Narebski, Jun 29, 2006
  5. autoconf: Cleanup generation of config.mak.append by ./configureJakub Narebski, Jun 29, 2006
  6. Allow INSTALL, bindir, mandir to be set in main MakefileJakub Narebski, Jun 29, 2006
  7. autoconf: Set mandir in config.mak.in and export variables not in MakefileJakub Narebski, Jun 29, 2006
  8. autoconf: configure.ac uses variables to set in, out and temp filesJakub Narebski, Jun 30, 2006
  9. autoconf: ./configure script outputs to config.mac.autoJakub Narebski, Jun 30, 2006
  10. autoconf: Cleanup generation of temporary "append" fileJakub Narebski, Jun 30, 2006
  11. autoconf: Write how to use ./configure generated file in git build processJakub Narebski, Jun 30, 2006
  12. autoconf: Rename ./configure output file to config.mak.autogenJakub Narebski, Jun 30, 2006
  13. Revert "autoconf: Write how to use ./configure generated file in git build process"Jakub Narebski, Jun 30, 2006
  14. autoconf: Append '-include config.mak.autogen' to config.mak if it is not presentJakub Narebski, Jun 30, 2006
  15. Jakub NarebskiJun 30, 2006
  16. autoconf: Added --with/--without for openssl, curl, expat to ./configureJakub Narebski, Jun 30, 2006
  17. Pavel RoskinJun 30, 2006
  18. Jakub NarebskiJun 30, 2006
  19. Jakub NarebskiJun 30, 2006
  20. Junio C HamanoJun 29, 2006
  21. Jakub NarebskiJun 29, 2006
  22. Matthias LederhoferJun 29, 2006
  23. Jakub NarebskiJun 29, 2006
  24. Andreas EricssonJun 30, 2006
  25. Jakub NarebskiJun 30, 2006
  26. Jakub NarebskiJul 1, 2006
  27. Junio C HamanoJun 29, 2006
  28. Jakub NarebskiJul 1, 2006
  29. Pavel RoskinJul 8, 2006
  30. Jakub NarebskiJul 1, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.