Re: [RFC] gitweb wishlist and TODO list
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 21, 2006, 13:30 UTC
- Message-ID
- <e7bhlf$5j2$1@sea.gmane.org>
- In-Reply-To
- <20060621130535.G2b34d382@leonov.stosberg.net>
Dennis Stosberg wrote:
Show 12 quoted lines
> (2) Setting %ENV has no effect on spawned processes under mod_perl, > so the git commands would never find the project directories. > My first thought was to set $GIT_DIR on the commands' command > lines like in open($fh, '$GIT_DIR=blah git-rev-list ...') but it > would lead to an extra shell being spawned on every invocation > of a git command. > > So I added the possibility to set/override the path to the > repository with a command line parameter. For simplicity I > handled that parameter in git.c. The drawbacks are that it has > to be given before the command name and that it won't work when > commands are invoked as "git-command".
So now you have extra git redirector being spawned, instead of extra shell being spawned. I wonder if using 'env' wouldn't be simplier, and how portable 'env' is.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git