Re: [PATCH] send-email: Use setlocale in addition to $ENV{LC_ALL} to set locale

From: Jakub Narebski <jnareb@gmail.com>
Date: Jun 21, 2006, 11:18 UTC
Message-ID: <e7b9u7$974$1@sea.gmane.org>
In-Reply-To: <20060621104941.GB15748@localdomain>

Eric Wong wrote:

> Jakub Narebski <jnareb@gmail.com> wrote:
>> 
>>> $ENV{LC_ALL} = 'C'; does not change locale used by strftime.
>>> Use setlocale( &LC_ALL, 'C' ); instead.

> I'm responsible for the $ENV{LC_ALL} = 'C' setting but I never actually
> tested how things would work with a non-English locale (not being
> well-versed in these things myself, either).

It looks like I have broken locale badly somewhat, as I yesterday sent patches successfully without the patch. I suspect that sendmail removes incorrect Date: header and adds it's own... unless Date: header contains characters outside US-ASCII.

It means that sendmail can deal with
  Date: wto, 20 cze 2006 13:14:11 +0200
instead of correct
  Date: Tue, 20 Jun 2006 13:14:11 +0200

but cannot deal with (iso-8859-2 encoded I think)
  Date: ¶ro, 21 cze 2006 09:48:02 +0200
from git-send-email.perl without patch, instead of correct
  Date: Wed, 21 Jun 2006 11:25:52 +0200
with the patch.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git