Re: [PATCH v2 1/1] [PATCH] mimgw: remove Compiler Warnings

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Oct 10, 2024, 08:59 UTC
Message-ID: <e7646092-84e0-4210-88e9-98352e1f60e0@gmail.com>
In-Reply-To: <20241009171342.2354-2-soekkle@freenet.de>

Hi Sören

On 09/10/2024 18:13, Sören Krecker wrote:

> Remove some compiler warnings from msvc in compat/mingw.c for value truncation from 64 bit to 32 bit intigers.

Thanks for re-rolling, I think "Fix some compiler warnings" would be clearer than "Remove", also "integers" is misspelt. As Junio said we fold our commit messages at 72 characters. When I said it would be helpful to explain the choice of signed/unsigned I meant an explanation in the commit message, not code comments. I agree with Junio that the remaining ssize_t should be a size_t so the commit message could say something like

     Use size_t instead of int as all of the changed variables hold the
     result of strlen() or wcslen() which cannot be negative.

It would also be helpful to explain in the commit message the changes to _ssize_t

Show 5 quoted lines

> +#ifdef _WIN64
> +typedef __int64 _ssize_t;
> +#else
>   typedef long _ssize_t;
> +#endif // _AMD64

Please note that we do not use "//" comments so this should be "/* _WIN64 */" so that the comment matches the opening #ifdef

Thanks for working on this

Phillip