Re: [QGIT PATCH/RFC]

From: Marco Costalba <mcostalba@gmail.com>
Date: Nov 5, 2009, 09:41 UTC
Message-ID: <e5bfff550911050141t751d45a0r4e340fa0d10af366@mail.gmail.com>
In-Reply-To: <4AF19630.2070402@lyx.org>

Hi Abdel,

On Wed, Nov 4, 2009 at 15:56, Abdelrazak Younes <younes@lyx.org> wrote:

Show 6 quoted lines

> Hello Marco,
>
> While recompiling latest qgit4, I stumbled accross this. I am not quite sure
> you used a QLatin1String instead of a QByteArray but the attached seems to
> work fine...
>

Unfortunatly I cannot say the same here ;-)

>-class ShaString;
>+typedef QByteArray ShaString;

...... cut ......

>
>  uint qHash(const ShaString& s) { // fast path, called 6-7 times per
> revision
>

Function:

uint qHash(const QByteArray&);

is already defined in the Qt Core libraries, so I have a link error with your patch.

BTW I don't think I have understood the reason of your patch. Do you have a compile error or something ?

Thanks

Marco