Re: [QGIT PATCH] Add safeguards to Git::userInfo()

From: Marco Costalba <mcostalba@gmail.com>
Date: Oct 7, 2008, 18:03 UTC
Message-ID: <e5bfff550810071103j52ce2617iae2f77b9bd3fba93@mail.gmail.com>
In-Reply-To: <48EB9EB1.7080302@lyx.org>

On Tue, Oct 7, 2008 at 6:38 PM, Abdelrazak Younes <younes@lyx.org> wrote:

>
> So how do you explain this:
>

Form git-config(1) docs:

This command will fail if:

-The config file is invalid, ...... -you use --global option without $HOME being properly set.

So please try to comment out following line

--- a/src/git.cpp
+++ b/src/git.cpp
@@ -345,7 +345,7 @@ void Git::userInfo(SList info) {
 	info.clear();
 	info << "Environment" << user << email;

-	errorReportingEnabled = false; // 'git config' could fail, see docs
+	//errorReportingEnabled = false; // 'git config' could fail, see docs

 	run("git config user.name", &user);
 	run("git config user.email", &email);


run from double click and you probably will see an error message box
where git says $HOME is not set (I can reproduce this now).

So what I think is that when you run from command line there is the
$HOME variable set and command does not fails.


Marco