git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] Use new compress helpers in builtin-pack-objects.c

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Jan 11, 2008, 06:10 UTC
Message-ID
<e5bfff550801102210g181a091s28725e24922b9b12@mail.gmail.com>
In-Reply-To
<e5bfff550801101334p5df5adaerf0eeae02ddf28334@mail.gmail.com>
On Jan 10, 2008 10:34 PM, Marco Costalba <mcostalba@gmail.com> wrote:
Show 6 quoted lines
>
> -               while (deflate(&stream, Z_FINISH) == Z_OK)
> -                       /* nothing */;
> -               deflateEnd(&stream);
> -               datalen = stream.total_out;
> -               deflateEnd(&stream);

One thing I would like someone to clarify is why deflateEnd(&stream) is called two times ?

With my patch is called only once as I have seen in all the others places.

Thanks Marco

Previous: Nicolas PitreNext: Junio C Hamano
Message 3 of 4 in “Use new compress helpers in builtin-pack-objects.c”
  1. 6/6 Use new compress helpers in builtin-pack-objects.cMarco Costalba, Jan 10, 2008
  2. Nicolas PitreJan 10, 2008
  3. Marco CostalbaJan 11, 2008
  4. Junio C HamanoJan 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.