Re: [QGit PATCH] Remove most ASSERT warnings in Git::setStatus
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- May 20, 2007, 16:06 UTC
- Message-ID
- <e5bfff550705200906x5464dc6bnc31954f5d1dcddd@mail.gmail.com>
- In-Reply-To
- <200705201641.20305.barra_cuda@katamail.com>
On 5/20/07, Michael <barra_cuda@katamail.com> wrote:
Show 18 quoted lines
> "Marco Costalba" <mcostalba@gmail.com>:
> > So I rather would prefer something like
> >
> > line.section('\t', 0, 0).section(' ', -1, -1).left(1)
> >
> > because we could have more then one file separated by a tab, so
> >
> > line.section('\t', -2, -2).right(1)
> >
> > it seems to me a little bit fragile. What do you think?
>
> You're right.
>
> > Also I don't understand why you consider the right most (right(1)),
> > instead of the left most character as the status.
>
> Only because it was simpler AND because I didn't know it was wrong.
>Patch pushed to public repo both for qgit and qgit4.
Grazie per il report Marco