Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message

From: Marco Costalba <mcostalba@gmail.com>
Date: Feb 23, 2007, 08:03 UTC
Message-ID: <e5bfff550702230003o5a24a422h7c52a544318da1d4@mail.gmail.com>
In-Reply-To: <200702181044.53115.andyparkins@gmail.com>

On 2/18/07, Andy Parkins <andyparkins@gmail.com> wrote:

Show 11 quoted lines

> On Sunday 2007, February 18, Marco Costalba wrote:
>
> > thanks for your patches, but I can see only this email and the
> > '[PATCH 2/3] Improve default column widths by changing resize modes',
> > I miss body of [PATCH 1/3]  and  [PATCH 3/3].
>
> I think that the mailing list spam filter is objecting because the email
> contains HTML tags.  I'll send the patches to you directly to bypass
> the spam filter.
>
>

Hi Andy,

 I finally apply and pushed your patches to
git://repo.or.cz/qgit4.git, I have to say I really like your fancy
html log message.

Just a couple of notes:

- Font family is set to TYPE_WRITER_FONT, but font size is not taken
into account and seems fixed.

- There are some alignement issues in the header, sometimes author,
date, etc.. are left shifted without a clear reason wasting valuable
screen space.

Here are some snapshots to better clarify the points.

http://digilander.libero.it/mcostalba/andy1.png http://digilander.libero.it/mcostalba/andy2.png http://digilander.libero.it/mcostalba/andy3.png

Anyway a nice job.

Thanks Marco