Re: [PATCH] qgit: Default the log window to wider than the file list and set monospaced font

From: Marco Costalba <mcostalba@gmail.com>
Date: Feb 8, 2007, 19:29 UTC
Message-ID: <e5bfff550702081129x6c94eaa4p40cf09e70c4e09cd@mail.gmail.com>
In-Reply-To: <200702081913.09952.andyparkins@gmail.com>

On 2/8/07, Andy Parkins <andyparkins@gmail.com> wrote:

Show 9 quoted lines

> On Thursday 2007, February 08 19:06, Marco Costalba wrote:
>
> > I have applied and pushed all your patches. BTW you are referring to
> > qgit4 at Pasky http://repo.or.cz/ site, not the stable qgit in
> > kernel.org repo!
>
> My apologies - that was the first one I found when I typed qgit4
> repository.
>

No problem, stable qgit has less layout problems, probably the only patch I will back port is the fixed font in log viewer.

qgit4 seems to have more layout weirdeness also in patch and file tabs. I didn't fixed it until because I'm still wondering if it is enough fixing the layout using stretch factors or bite the bullet and implement a geometry persistent saving with QSettings (Qt4 is quite powerful in this regard), of course saved geometry should work both with maximized and not-maximized window, so perhaps saving panes/splitters factors is better then save absolute value at least for 'internal' widget, and use absolute window geometry only for qgit main window.

Show 10 quoted lines

>
> > P.S: Yes, I have noted this Qt::convertFromPlainText() misbehaviour,
> > but I don't know if are the spaces that are not escaped correctly by
> > the function or the QTextEdit rendering engine that eats the
> > (escaped) spaces anyway.
>
> I definitely think this is a bug in Qt; QTextBrowser will show the
> spaces in HTML mode if <pre> is used, so I don't think it's a fault in
> QTextBrowser.
>

Please add dbg(text) line in git.cpp, just below Qt::convertFromPlainText(text) call

		text.append("\n\n    " + colorMatch(c->shortLog(), shortLogRE) +
		            '\n' + colorMatch(c->longLog(), longLogRE));
	}
	text = Qt::convertFromPlainText(text);
dbg(text);
	// highlight SHA's
	//
	// added to commit logs, we avoid to call git rev-parse for a
possible abbreviated
	// sha if there isn't a leading trailing space or an open parenthesis and,

This will print the converted text as plain string, as you can see there is 'something' instead of spaces but I cannot guess what.

Show 25 quoted lines

> > P.P.S: Give a try to Bitstream Vera Sans Mono as fixed width font,
> > it's muuuuuch better then Monospace IMHO ;-)
>
> No need to persuade me; that's what I already use.  Monospace isn't a
> font on most systems - it's an alias to the default monospaced font -
> and for me it's aliased to Bitstream Mono :-)
>
> It seems to be done by the following in /etc/fonts/
>
>     <alias>
>         <family>Bitstream Vera Sans Mono</family>
>         <family>DejaVu Sans Mono</family>
>         <family>Courier</family>
>         <family>Courier New</family>
>         <family>Andale Mono</family>
>         <family>Luxi Mono</family>
>         <family>Cumberland AMT</family>
>         <family>Nimbus Mono L</family>
>         <family>NSimSun</family>
>         <family>FreeMono</family>
>         <default><family>monospace</family></default>
>     </alias>
>
> In case that helps you.
>

Thanks