git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC \ WISH] Add -o option to git-rev-list

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Dec 15, 2006, 18:45 UTC
Message-ID
<e5bfff550612151045q5782e1f2j8686ccab24dbf566@mail.gmail.com>
In-Reply-To
<Pine.LNX.4.64.0612111258050.3515@woody.osdl.org>
On 12/11/06, Linus Torvalds <torvalds@osdl.org> wrote:
>
>
> So I don't think there is a right answer here. I suspect QProcess does ok.
>

I have just pushed a patch (wiil be available in few hours I suspect) to easily choose the data exchange facility with git-rev-list.

Default its temporary file based, but after uncommenting the USE_QPROCESS define in dataloader.cpp and compile again, qgit will use a QProcess based approach to connect with git-rev-list.

Only the low level connection is different in the two cases, _all_ the rest, expecially data storing and parsing, is the same. If you take a look at src/dataloader.cpp you will see that the difference between QProcess and temp file code is minumum.

I've also tried to clearly report in comments the different approaches and the data copy involved in both cases. I've searched a little bit in QProcess sources too to get some additional info.

And finally these are mine warm and cold cache tests.

Load time test on Linux tree (44557 revs, 32167KB) CPU Mobile Pentium 4 set at 1.2GHZ

To set data read interval in ms use (src/dataloader.cpp): #define GUI_UPDATE_INTERVAL 500

Warmed-up cache QProcess 7632ms (500ms data read interval) QProcess 7972ms (100ms data read interval)

Temporary file 4408ms (500ms data read interval) Temporary file 4591ms (100ms data read interval)

Cold cache QProcess 25611ms (500ms data read interval)

File 22399ms (500ms data read interval)
Previous: Linus TorvaldsNext: Linus Torvalds
Message 26 of 36 in “[RFC \ WISH] Add -o option to git-rev-list”
  1. Marco CostalbaDec 10, 2006
  2. Alex RiesenDec 10, 2006
  3. Linus TorvaldsDec 10, 2006
  4. Marco CostalbaDec 10, 2006
  5. Linus TorvaldsDec 10, 2006
  6. Linus TorvaldsDec 10, 2006
  7. Marco CostalbaDec 10, 2006
  8. Marco CostalbaDec 10, 2006
  9. Linus TorvaldsDec 10, 2006
  10. Marco CostalbaDec 10, 2006
  11. Linus TorvaldsDec 10, 2006
  12. Marco CostalbaDec 11, 2006
  13. Linus TorvaldsDec 11, 2006
  14. Marco CostalbaDec 11, 2006
  15. Alex RiesenDec 11, 2006
  16. Linus TorvaldsDec 11, 2006
  17. Linus TorvaldsDec 11, 2006
  18. Marco CostalbaDec 11, 2006
  19. Linus TorvaldsDec 11, 2006
  20. Marco CostalbaDec 11, 2006
  21. Linus TorvaldsDec 11, 2006
  22. Josef WeidendorferDec 11, 2006
  23. Linus TorvaldsDec 11, 2006
  24. Josef WeidendorferDec 11, 2006
  25. Linus TorvaldsDec 11, 2006
  26. Marco CostalbaDec 15, 2006
  27. Linus TorvaldsDec 15, 2006
  28. Marco CostalbaDec 15, 2006
  29. Marco CostalbaDec 15, 2006
  30. Josef WeidendorferDec 11, 2006
  31. Marco CostalbaDec 11, 2006
  32. Josef WeidendorferDec 11, 2006
  33. Marco CostalbaDec 11, 2006
  34. Andreas EricssonDec 11, 2006
  35. Marco CostalbaDec 11, 2006
  36. Andreas EricssonDec 11, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.