Re: qgit segfaults after b237b00

From: Marco Costalba <mcostalba@gmail.com>
Date: Sep 12, 2006, 17:39 UTC
Message-ID: <e5bfff550609121039h1ef25bc8y25186c321d555b8e@mail.gmail.com>
In-Reply-To: <45068577.2020608@op5.se>

Hi Andreas,

On 9/12/06, Andreas Ericsson <ae@op5.se> wrote:

> What subject says, really. Tried cold cache, hot cache, with and without
> qgit.dat, 3 different repos and 14 different repo-tips. Same result
> every time. A segfault before anything is drawn.
>

Sorry but I am not able to reproduce the bug here. Also from the trace I see that the segfault happens in a part of code that has not been touched by b237b00. And that _should_ not segfault in any way.

The code there is the same of qgit-1.5.1 so perhaps could be some platform related issue, please write me Qt and gcc versions and processor used and, in case, do a complete rebuild with also reconfiguration (autoreconf -i).

What about the current qgit HEAD (6128112f36) , could you reproduce the bug also there?

>From the trace I see the segfault occurs in main view constructor,

i.e. before to touch anything. So it is not related to a particular repository.

> c++ is a scary thing to me,

C++ is really scary not because we don't understand the code, but because we _think_ to understand what the code does ;-)

Principle of least surprise is not exactly one of the design cornerstones of C++, at least for normal people sense of surprise.

>
> btw, kudos for a great tool.
>

Thanks to you for using it, and reporting bugs.

Any suggestion is very appreciated!

  Marco