Re: Some issues with current qgit on exit
- From
- Marco Costalba <mcostalba@gmail.com>
- Date
- Sep 6, 2006, 17:28 UTC
- Message-ID
- <e5bfff550609061028y25aeb928i2c49d4a5d1be7a60@mail.gmail.com>
- In-Reply-To
- <1157493650.2803.8.camel@dv>
On 9/6/06, Pavel Roskin <proski@gnu.org> wrote:
> Hi, Marco! >
Hello Pavel,
nice to hear you again!
Show 25 quoted lines
> The current qgit reports assertion failure on exit: > ASSERT in tabWdg_currentChanged > > That's how you can trigger it: > > select one of the patches > double click on the entry to open the "patch" tab > double click on one of the modified files on the right > switch back to the "rev list" or "patch" tab > close qgit by Ctrl-Q > > I've tried to debug the problem. MainImpl::currentTabType() returns -1. > It's possible that the logic in that function is flawed, or maybe it > doesn't work properly on exit. > > Another problem is segmentation fault when closing qgit with more that > one file tab and the "rev list" tab selected: > > select one of the patches > select "view file" in the pop-up menu on one of the files > activate the "rev list" tab > select "view file in new tab" on the same file > activate the "rev list" tab > close qgit by Ctrl-Q >
Thanks for the very good bug reports. I have just pushed the fix: it was a bogus delayed delete on exit the origin of this issues.
I was planning (well, still I am) to release new version this week end, and your bug report is arrived just in time ;-)
Thanks Marco