git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Cloning from sites with 404 overridden

From
MCMarco Costalba <mcostalba@gmail.com>
Date
Mar 20, 2006, 12:17 UTC
Message-ID
<e5bfff550603200417h71c083f9saebbf1fe6b21076c@mail.gmail.com>
In-Reply-To
<7v8xr5ld38.fsf@assigned-by-dhcp.cox.net>
On 3/20/06, Junio C Hamano <junkio@cox.net> wrote:
Show 20 quoted lines
> "Marco Costalba" <mcostalba@gmail.com> writes:
>
> >> This is totally untested, but maybe something like this?
> >
> > It works for me. Just some trailing white space warning when applying.
>
> The change only removes the error message without changing any
> other logic, so if that works for you, I wonder if leaving
> things as they are is a better option than doing anything short
> of implementing an AI that tries to pattern-match the "allegedly
> corrupt file" with "sorry no such page found" in many natural
> languages.
>
> My test patch makes it impossible to track down the real
> breakage when an HTTP-reachable repository _does_ have a corrupt
> object.
>
> So how about doing this instead?
>
> -- >8 --
Show 8 quoted lines
> +               fprintf(stderr,
> +"Some loose object were found to be corrupt, but they might be just\n"
> +"a false '404 Not Found' error message sent with incorrect HTTP\n"
> +"status code.  Suggest running git fsck-objects.\n");
> +       }
>         return rc;
>  }
>
I think it's better, read more correct.

Could be a real corrupted file or just a false 404, so better a warning then an error message and also better a warning then nothing.

Marco
Previous: Junio C HamanoNext: Lukas Sandström
Message 9 of 17 in “Cloning from sites with 404 overridden”
  1. Marco CostalbaMar 19, 2006
  2. Paolo CiarrocchiMar 19, 2006
  3. Marco CostalbaMar 19, 2006
  4. Junio C HamanoMar 19, 2006
  5. Marco CostalbaMar 19, 2006
  6. Junio C HamanoMar 19, 2006
  7. Marco CostalbaMar 20, 2006
  8. Junio C HamanoMar 20, 2006
  9. Marco CostalbaMar 20, 2006
  10. Lukas SandströmMar 20, 2006
  11. Petr BaudisMar 20, 2006
  12. Nick HengeveldMar 20, 2006
  13. Junio C HamanoMar 19, 2006
  14. Petr BaudisMar 19, 2006
  15. Petr BaudisMar 19, 2006
  16. Marco CostalbaMar 19, 2006
  17. Randal L. SchwartzMar 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.