[PATCH 1/4] send-email: don't attempt to prompt if tty is closed
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Mar 31, 2009, 16:22 UTC
- Message-ID
- <e439cc23328dc25d153baed21f6ad7d90106eb03.1238516122.git.jaysoffian@gmail.com>
- In-Reply-To
- <cover.1238516122.git.jaysoffian@gmail.com>
Attempting to prompt when the tty is closed (typically when running from cron) is pointless and emits a warning. This patch causes ask() to return early, squelching the warning.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com> --- git-send-email.perl | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 5916c86..d790660 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -612,6 +612,9 @@ sub ask { my $default = $arg{default}; my $resp; my $i = 0; + return defined $default ? $default : undef + unless defined $term->IN and defined fileno($term->IN) and + defined $term->OUT and defined fileno($term->OUT); while ($i++ < 10) { $resp = $term->readline($prompt); if (!defined $resp) { # EOF
-- 1.6.2.1.427.g15408