Re: [PATCH v2] config: set pack.useSparse=true by default

From: Derrick Stolee <stolee@gmail.com>
Date: Mar 20, 2020, 21:14 UTC
Message-ID: <e35c1bc5-7569-defc-2cee-e47039506521@gmail.com>
In-Reply-To: <xmqqmu8abvuf.fsf@gitster.c.googlers.com>

On 3/20/2020 4:43 PM, Junio C Hamano wrote:

Show 12 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>>     Here is a small patch to convert pack.useSparse to true by default. It's
>>     been released for over a year, so the feature is quite stable.
> 
> I would not say anything more than "its' been released for over a
> year, so the feature is known not to cause problems when it is not
> enabled (in other words, we coded our if/else correctly)", unless
> some telemetry tells us that significant number of users with widely
> differing use patterns have enabled it and are not seeing much
> negative effect.  And we can tell if it is stable only if we flip
> the default.

True. I've done my best to advertise the feature but have heard very little from users about it outside of our "captive audience" in the Windows OS team. I've also been using it myself (as part of features.experimental) on all of my machines, but that's hardly a vote for rigorous use in strange patterns.

Show 8 quoted lines

>> I'm submitting this now to allow it to cook for a while during the
>> next release cycle.
> 
> I agree that it is about time to see if flipping of default would be
> a good move for users whose usage patterns are unlike VFS for Git by
> cooking a change like this in 'next', definitely at least a cycle
> but possible a bit more, and it is a good idea to have it at the
> beginning of the next cycle.  Very much appreciated.

I'm happy to let you decide when this has cooked long enough. If you feel that more than one cycle is needed, then absolutely let's be cautious here.

Thanks, -Stolee