Re: [PATCH] git-cvsexportcommit can't commit files which have been removed from CVS

From: Mike Ralphson <mike.ralphson@gmail.com>
Date: Jun 10, 2009, 08:06 UTC
Message-ID: <e2b179460906100106x2b9c0bb4r931b0a12959d4314@mail.gmail.com>
In-Reply-To: <4A1F1CF5.8030002@yahoo.co.uk>

2009/5/29 Nick Woolley <nickwoolley@yahoo.co.uk>

> Added a test to t9200-git-cvsexportcommit.sh, which tests that we can
> re-commit a removed filename which remains in CVS's attic. This adds a
> file 'attic_gremlin' in CVS, then "removes" it, then tries to commit a
> file with the same name from git.

Hi Nick, I'm seeing intermittent failures since your new test was added to 'next' on AIX 5.3

cvs commit: Up-to-date check failed for ` space'
cvs [commit aborted]: correct above errors first!
* FAIL 15: re-commit a removed filename which remains in CVS attic
* failed 1 among 15 test(s)

Is there a possibility this test has a race condition?

Let me know if there's anything I can do to help debug it.

It could be a bug in the ancient CVS I have here (1.11.1p1) though.

cvs status: Examining .
===================================================================
File:  space            Status: Needs Patch

As it's a file from the previous tests being fingered, I've cc'd a couple of likely lads.

Mike