git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: allow --color-moved with --no-ext-diff

From
René Scharfe <l.s.r@web.de>
Date
Jun 23, 2024, 09:46 UTC
Message-ID
<e23dc86c-e32d-40f9-8305-86d4a25e79b6@web.de>
In-Reply-To
<trinity-5166e20d-147e-4205-99b7-f13a007ed5f9-1719134235233@3c-app-gmx-bap30>
Am 23.06.24 um 11:17 schrieb lolligerhans@gmx.de:
Show 5 quoted lines
> using red/green coloration is the current buggy behavior. When
> setting oldMOved and newMoved I would expect the correct behaviour to
> the the same as the buggy one.
>
> Could this test pass despite the bug?

Good question, but it doesn't. The test uses the colors "normal red" and "normal green" for moved lines, i.e. unchanged text color on red and green background, while regular changed lines use red and green text on unchanged background.

René
Previous: lolligerhans@gmx.deNext: Junio C Hamano
Message 4 of 9 in “Bug: diff.external --no-ext-diff suppresses --color-moved”
  1. lolligerhans@gmx.deJun 22, 2024
  2. diff: allow --color-moved with --no-ext-diffRené Scharfe, Jun 22, 2024
  3. Aw: [PATCH] diff: allow --color-moved with --no-ext-difflolligerhans@gmx.de, Jun 23, 2024
  4. René ScharfeJun 23, 2024
  5. Junio C HamanoJun 24, 2024
  6. René ScharfeJun 24, 2024
  7. Junio C HamanoJun 25, 2024
  8. diff: allow --color-moved with --no-ext-diffRené Scharfe, Jun 24, 2024
  9. Junio C HamanoJun 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.