git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] t: replace incorrect test_must_fail usage (part 4)

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 20, 2020, 11:49 UTC
Message-ID
<e231e2db-ecbd-5b74-f563-551d03f568fb@gmail.com>
In-Reply-To
<cover.1587372771.git.liu.denton@gmail.com>
On 4/20/2020 4:54 AM, Denton Liu wrote:
Show 5 quoted lines
> The overall scope of these patches is to replace inappropriate uses of
> test_must_fail. IOW, we should only allow test_must_fail to run on `git`
> and `test-tool`. Ultimately, we will conclude by making test_must_fail
> error out on non-git commands. An advance view of the final series can
> be found here[1].

I appreciate your efforts here to use best-practices throughout the test suite. Too often I look at a test script as an example on which to base a new test, but then I just repeat a bad pattern.

This series looks good to me.

Thanks, -Stolee

Previous: Denton Liu
Message 20 of 20 in “t: replace incorrect test_must_fail usage (part 4)”
  1. 0/8 t: replace incorrect test_must_fail usage (part 4)Denton Liu, Apr 20, 2020
  2. 2/8 t7408: replace incorrect uses of test_must_failDenton Liu, Apr 20, 2020
  3. 3/8 t7508: don't use `test_must_fail test_cmp`Denton Liu, Apr 20, 2020
  4. Johannes SixtApr 21, 2020
  5. 1/8 t6030: use test_path_is_missing()Denton Liu, Apr 20, 2020
  6. 4/8 t9141: use test_path_is_missing()Denton Liu, Apr 20, 2020
  7. 5/8 t9160: use test_path_is_missing()Denton Liu, Apr 20, 2020
  8. 6/8 t9164: don't use `test_must_fail test_cmp`Denton Liu, Apr 20, 2020
  9. Eric SunshineApr 20, 2020
  10. Junio C HamanoApr 20, 2020
  11. Eric SunshineApr 20, 2020
  12. Denton LiuApr 21, 2020
  13. Junio C HamanoApr 21, 2020
  14. Denton LiuApr 22, 2020
  15. Junio C HamanoApr 22, 2020
  16. 8/8 t9902: don't use `test_must_fail __git_*`Denton Liu, Apr 20, 2020
  17. Johannes SixtApr 21, 2020
  18. Denton LiuApr 22, 2020
  19. 7/8 t9819: don't use test_must_fail with p4Denton Liu, Apr 20, 2020
  20. Derrick StoleeApr 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.