git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Potential bug in --color-words output

From
SKSimeon Krastnikov <skrastnikov@gmail.com>
Date
Oct 28, 2022, 21:08 UTC
Message-ID
<e2164b04-98de-6f19-6c33-6979c1a328ff@gmail.com>
Hello,

Given an initial file with the contents "not to be", which I then change to "to be", the output of 'git diff --color-words', is

   notto be

with the first three letters colored red. To me this seems incorrect as it implies, or at least misleadingly suggests, that there was no space between "not" and "to" in the original file. (Even though in that case the output is actually "nottoto be" with the "notto" in red and "to" in green.)

If instead I start with a file with contents "to be", which I then change to "not to be", then the output is as expected:

   not to be
(First three letters colored green.)

Am I correct in seeing this as a bug? If so, any tips on what parts of diff.c to look at when starting a patch?

Thanks,
Simeon
Next: Johannes Sixt
Message 1 of 4 in “Potential bug in --color-words output”
  1. Simeon KrastnikovOct 28, 2022
  2. Johannes SixtNov 8, 2022
  3. Johannes SchindelinNov 10, 2022
  4. Stefan BellerNov 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.