git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] object-name: declare pointer type of extend_abbrev_len()'s 2nd parameter

From
René Scharfe <l.s.r@web.de>
Date
Sep 4, 2025, 17:58 UTC
Message-ID
<e0bc9a67-faa9-4218-a55a-c7d53c15cfce@web.de>

Expose the expected type of the second parameter of extend_abbrev_len() instead of casting a void pointer internally. Just a single caller passes in a void pointer, the rest pass the correct type. Let the compiler help keeping it that way.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 object-name.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/object-name.c b/object-name.c
index 732056ff5e..1e0118e8a6 100644
--- a/object-name.c
+++ b/object-name.c
@@ -696,10 +696,9 @@ static inline char get_hex_char_from_oid(const struct object_id *oid,
 		return hex[oid->hash[pos >> 1] & 0xf];
 }
 
-static int extend_abbrev_len(const struct object_id *oid, void *cb_data)
+static int extend_abbrev_len(const struct object_id *oid,
+			     struct min_abbrev_data *mad)
 {
-	struct min_abbrev_data *mad = cb_data;
-
 	unsigned int i = mad->init_len;
 	while (mad->hex[i] && mad->hex[i] == get_hex_char_from_oid(oid, i))
 		i++;
-- 
2.51.0
Next: Junio C Hamano
Message 1 of 4 in “object-name: declare pointer type of extend_abbrev_len()'s 2nd parameter”
  1. object-name: declare pointer type of extend_abbrev_len()'s 2nd parameterRené Scharfe, Sep 4, 2025
  2. Junio C HamanoSep 4, 2025
  3. René ScharfeSep 7, 2025
  4. Junio C HamanoSep 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.