Re: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_()
Hi Keryle
On 19/10/2026 16:27, kerylefondji7@gmail.com wrote:
Show 5 quoted lines
> From: Keryle Fondji <kerylefondji7@gmail.com>
> > Replace _() with Q_() in the 'path too long' error message. Although
> pathlen is always greater than 0xffff when this error is hit, Q_() is
> required to support correct translation for languages that require
> different plural forms depending on the count.
This is good. As Junio has pointed out the code needs wrapping now that it is using Q_().
Thanks
Phillip
Show 16 quoted lines
> Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com>
> ---
> archive-zip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/archive-zip.c b/archive-zip.c
> index 6f73ca6d58..e4f8ef5a36 100644
> --- a/archive-zip.c
> +++ b/archive-zip.c
> @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,
> }
> > if (pathlen > 0xffff) {
> - return error(_("path too long (%d chars, SHA1: %s): %s"),
> + return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen),
> (int)pathlen, oid_to_hex(oid), path);
> }
>