git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Make GIT-VERSION-GEN tolerate missing git describe command

From
JEJohn Ellson <ellson@research.att.com>
Date
Dec 30, 2005, 16:23 UTC
Message-ID
<dp3mtp$rfm$1@sea.gmane.org>

I think it is probably a bug that "git non_existent_command" returns its error message to stdout without an error, where "git-non_existent_command" behaves differently and does return an error.

Older versions of git did not implement "git describe" and GIT-VERSION-GEN produces an empty version string if run on a system with such a git installed. The consequence is that "make rpm" fails.

This patch fixes GIT-VERSION-GEN so that it works in the absence of a working "git describe"

----------------------------------------
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 196402c..845b9dc 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -2,7 +2,7 @@

  GVF=GIT-VERSION-FILE

-VN=$(git describe --abbrev=4 HEAD 2>/dev/null) || VN=v1.0.GIT
+VN=$(git-describe --abbrev=4 HEAD 2>/dev/null) || VN=v1.0.GIT
  VN=$(expr "$VN" : v'\(.*\)')
  if test -r $GVF
  then

----------------------------------------


Signed-off-by: John Ellson <ellson@research.att.com>
Next: Linus Torvalds
Message 1 of 6 in “Make GIT-VERSION-GEN tolerate missing git describe command”
  1. Make GIT-VERSION-GEN tolerate missing git describe commandJohn Ellson, Dec 30, 2005
  2. Linus TorvaldsDec 30, 2005
  3. John EllsonDec 30, 2005
  4. Linus TorvaldsDec 30, 2005
  5. John EllsonDec 30, 2005
  6. H. Peter AnvinDec 31, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.