git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rerere-train: modernise a bit

From
Derrick Stolee <derrickstolee@github.com>
Date
Feb 20, 2022, 19:52 UTC
Message-ID
<dfa34726-6133-01e5-c591-22f3ce1f8363@github.com>
In-Reply-To
<xmqqsfsjuw8m.fsf@gitster.g>
On 2/16/2022 2:05 AM, Junio C Hamano wrote:
Show 9 quoted lines
> The script wants to create a list of merges using "rev-list" and
> filters commits that do not have more than one parent, but if we
> always pass "--merges" to "rev-list", there is no need to filter.
> 
> The command uses "git show --pretty=format:..." on a single commit
> while generating progress reports, which means this title line is
> left unterminated.  It should have used --pretty=tformat:...
> instead, or better yet, use the more modern --format=... to ensure
> that the title line is properly terminated.

I'm unfamiliar with the rerere-train.sh script, but the changes are pretty clearly achieving what you describe here.

Thanks, -Stolee

Previous: Junio C HamanoNext: Johannes Altmanninger
Message 2 of 8 in “rerere-train: modernise a bit”
  1. rerere-train: modernise a bitJunio C Hamano, Feb 16, 2022
  2. Derrick StoleeFeb 20, 2022
  3. Johannes AltmanningerFeb 27, 2022
  4. Re* [PATCH] rerere-train: modernise a bitJunio C Hamano, Feb 27, 2022
  5. Johannes AltmanningerFeb 27, 2022
  6. Junio C HamanoFeb 27, 2022
  7. rerere-train: two fixes to the use of "git show -s"Junio C Hamano, Feb 27, 2022
  8. Johannes AltmanningerFeb 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.