Re: [PATCH] rerere-train: modernise a bit
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Feb 20, 2022, 19:52 UTC
- Message-ID
- <dfa34726-6133-01e5-c591-22f3ce1f8363@github.com>
- In-Reply-To
- <xmqqsfsjuw8m.fsf@gitster.g>
On 2/16/2022 2:05 AM, Junio C Hamano wrote:
Show 9 quoted lines
> The script wants to create a list of merges using "rev-list" and > filters commits that do not have more than one parent, but if we > always pass "--merges" to "rev-list", there is no need to filter. > > The command uses "git show --pretty=format:..." on a single commit > while generating progress reports, which means this title line is > left unterminated. It should have used --pretty=tformat:... > instead, or better yet, use the more modern --format=... to ensure > that the title line is properly terminated.
I'm unfamiliar with the rerere-train.sh script, but the changes are pretty clearly achieving what you describe here.
Thanks, -Stolee