Re: [PATCH] t8005: Nobody writes Russian in shift_jis

> The second and third tests of this script expected that Russian strings
> are converted between ISO-8859-5 and Shift_JIS in the "blame --porcelain"
> format output correctly.
> 
> Sure, many platforms may convert between such a combination, but that is
> only because one of the base character set of Shift_JIS, JIS X 0208,
> defines codepoints for Russian characters (among others); I do not think
> anybody uses Shift_JIS when seriously writing Russian, and it is perfectly
> understandable if iconv() libraries on some platforms fail converting
> between this combination, as it does not matter in reality.
> 
> This patch changes the test to verify Japanese strings are converted
> correctly between EUC-JP and Shift_JIS in the same procedure.  The point
> of the test is not about verifying the platform's iconv() library, but to
> see if "git blame" makes correct iconv() library calls when it should.
> 
> We could instead use ISO-8859-5 and KOI8-R as the combination, because
> they are both meant to represent Russian, in order to make this test
> meaningful on more platforms, but we already use Shift_JIS vs EUC-JP
> combinations to test other programs in our test suite, so this combination
> is safer from the point of view of the portability.  Besides, I do not
> read nor write Russian; sorry ;-)
> 
> This change allows tests to pass on my (friend's) Solaris 5.11 box.