[PATCH 1/7] merge-ort: mark a few more conflict messages as omittable
- From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Aug 31, 2021, 02:26 UTC
- Message-ID
- <df6e2774f1a5560a598dd8b46131bc6b0a261d4a.1630376800.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1080.git.git.1630376800.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>
path_msg() has the ability to mark messages as omittable when recording conflict messages in an in-tree file. This conflict message file will then be shown by diffing the merge-created tree to the actual merge commit that is created. While all the messages touched in this commit are very useful when trying to create a merge initially, early use with the --remerge-diff feature (the only user of this omittable conflict message capability), suggests that the particular messages marked in this commit are just noise when trying to see what changes users made to create a merge commit. Mark them as omittable.
Signed-off-by: Elijah Newren <newren@gmail.com> --- merge-ort.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/merge-ort.c b/merge-ort.c index 515dc39b7f6..4dbf0a477af 100644 --- a/merge-ort.c +++ b/merge-ort.c @@ -2409,7 +2409,7 @@ static void apply_directory_rename_modifications(struct merge_options *opt, */ ci->path_conflict = 1; if (pair->status == 'A') - path_msg(opt, new_path, 0, + path_msg(opt, new_path, 1, _("CONFLICT (file location): %s added in %s " "inside a directory that was renamed in %s, " "suggesting it should perhaps be moved to " @@ -2417,7 +2417,7 @@ static void apply_directory_rename_modifications(struct merge_options *opt, old_path, branch_with_new_path, branch_with_dir_rename, new_path); else - path_msg(opt, new_path, 0, + path_msg(opt, new_path, 1, _("CONFLICT (file location): %s renamed to %s " "in %s, inside a directory that was renamed " "in %s, suggesting it should perhaps be " @@ -3814,7 +3814,7 @@ static void process_entry(struct merge_options *opt, reason = _("add/add"); if (S_ISGITLINK(merged_file.mode)) reason = _("submodule"); - path_msg(opt, path, 0, + path_msg(opt, path, 1, _("CONFLICT (%s): Merge conflict in %s"), reason, path); }
-- gitgitgadget