Re: What's cooking in git.git (Apr 2023, #03; Tue, 11)

From: Victoria Dye <vdye@github.com>
Date: Apr 13, 2023, 22:19 UTC
Message-ID: <df61d79b-8234-d3fd-5eb5-614d1b97d046@github.com>
In-Reply-To: <xmqqo7ns69sz.fsf@gitster.g>

Junio C Hamano wrote:

Show 8 quoted lines

> * rn/sparse-diff-index (2023-04-10) 1 commit
>  - diff-index: enable sparse index
> 
>  "git diff-index" command has been taught to work better with the
>  sparse index.
> 
>  Comments?
>  source: <20230408112342.404318-1-nanth.raghul@gmail.com>

I just sent a review of the newest version [1] with some minor nits & questions that may prompt a re-roll (depending on the author's/others' thoughts).

[1] https://lore.kernel.org/git/62821012-4fc3-5ad8-695c-70f7ab14a8c9@github.com/

Show 7 quoted lines

> * rn/sparse-describe (2023-04-03) 1 commit
>  - describe: enable sparse index for describe
> 
>  "git describe --dirty" learns to work better with sparse-index.
> 
>  Will merge to 'next'?
>  source: <20230403164749.246001-1-nanth.raghul@gmail.com>

This looks good to me, agreed that it's ready for 'next'.

Show 8 quoted lines

> * sl/sparse-write-tree (2023-04-04) 1 commit
>   (merged to 'next' on 2023-04-10 at 0cd39c23b1)
>  + write-tree: integrate with sparse index
> 
>  "git write-tree" learns to work better with sparse-index.
> 
>  Will merge to 'master'.
>  source: <20230404003539.1578245-1-cheskaqiqi@gmail.com>

Sorry for getting to this one so late - I did have some comments [2] on the tests in this patch that weren't addressed. However, I'm fairly certain the integration itself is correct, so I may just submit the test updates as a separate patch in the (near-ish?) future.

[2] https://lore.kernel.org/git/9d0309bd-943c-dd51-97cf-59721eda78f7@github.com/

Show 8 quoted lines

> * sl/diff-files-sparse (2023-03-22) 2 commits
>  - diff-files: integrate with sparse index
>  - t1092: add tests for `git diff-files`
> 
>  Teach "diff-files" not to expand sparse-index unless needed.
> 
>  Comments?
>  source: <20230322161820.3609-1-cheskaqiqi@gmail.com>

I also just sent a review for this one [3] [4], with similar nits & questions to those in the 'diff-index' integration.

[3] https://lore.kernel.org/git/4ffff8e9-3e03-9c5f-4a42-b9102ed24e66@github.com/ [4] https://lore.kernel.org/git/c382017a-8c65-24ba-5092-6b46428d8b9b@github.com/