Re: [PATCH v4 3/3] add -p tests: remove Perl prerequisite

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Feb 7, 2024, 13:51 UTC
Message-ID: <df1fc65f-8716-47bb-b379-1e1f1eeece8b@gmail.com>
In-Reply-To: <8baa44ef-4960-4f0d-8cab-38d3d6ff971a@gmail.com>

On 07/02/2024 10:50, Phillip Wood wrote:

Show 15 quoted lines

> Hi Ghanshyam
> 
> On 06/02/2024 22:50, Ghanshyam Thakkar wrote:
>  > The Perl version of the add -i/-p commands has been removed since
>  > 20b813d (add: remove "add.interactive.useBuiltin" & Perl "git
>  > add--interactive", 2023-02-07)
>  >
>  > Therefore, Perl prerequisite in t2071-restore-patch and
>  > t7105-reset-patch is not necessary.
> 
> Thanks for adding this patch. If you do re-roll I've just noticed that 
> one of the tests in t7106-reset-unborn-branch.sh and another in 
> t2024-checkout-dwim.sh still have PERL prerequisites as well. I don't 
> think it is worth re-rolling just for that as we can clean them up 
> separately if needed.

I didn't cast my net wide enough when I was grepping earlier, t7514-commit-patch.sh and t3904-stash-patch.sh also have unnecessary PERL prerequisites

Best Wishes

Phillip