git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/10] Move commit_list_count() to commit.c

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Jun 11, 2008, 20:50 UTC
Message-ID
<dedcc8309fed3282df455bec7fbc9d0f8275b74b.1213217187.git.vmiklos@frugalware.org>
In-Reply-To
<4818a0b71b7f6b44ef49621045a5871458ba5c38.1213217187.git.vmiklos@frugalware.org>

This function is useful outside builtin-merge-recursive, for example in builtin-merge.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 builtin-merge-recursive.c |    8 --------
 commit.c                  |    8 ++++++++
 commit.h                  |    1 +
 3 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/builtin-merge-recursive.c b/builtin-merge-recursive.c
index 4aa28a1..98b09fb 100644
--- a/builtin-merge-recursive.c
+++ b/builtin-merge-recursive.c
@@ -42,14 +42,6 @@ static struct tree *shift_tree_object(struct tree *one, struct tree *two)
  * - *(int *)commit->object.sha1 set to the virtual id.
  */
 
-static unsigned commit_list_count(const struct commit_list *l)
-{
-	unsigned c = 0;
-	for (; l; l = l->next )
-		c++;
-	return c;
-}
-
 static struct commit *make_virtual_commit(struct tree *tree, const char *comment)
 {
 	struct commit *commit = xcalloc(1, sizeof(struct commit));
diff --git a/commit.c b/commit.c
index e2d8624..bbf9c75 100644
--- a/commit.c
+++ b/commit.c
@@ -325,6 +325,14 @@ struct commit_list *commit_list_insert(struct commit *item, struct commit_list *
 	return new_list;
 }
 
+unsigned commit_list_count(const struct commit_list *l)
+{
+	unsigned c = 0;
+	for (; l; l = l->next )
+		c++;
+	return c;
+}
+
 void free_commit_list(struct commit_list *list)
 {
 	while (list) {
diff --git a/commit.h b/commit.h
index 2d94d41..7f8c5ee 100644
--- a/commit.h
+++ b/commit.h
@@ -41,6 +41,7 @@ int parse_commit_buffer(struct commit *item, void *buffer, unsigned long size);
 int parse_commit(struct commit *item);
 
 struct commit_list * commit_list_insert(struct commit *item, struct commit_list **list_p);
+unsigned commit_list_count(const struct commit_list *l);
 struct commit_list * insert_by_date(struct commit *item, struct commit_list **list);
 
 void free_commit_list(struct commit_list *list);
-- 
1.5.6.rc2.dirty
Previous: Miklos VajnaNext: Miklos Vajna
Message 3 of 14 in “Build in merge”
  1. 00/10 Build in mergeMiklos Vajna, Jun 11, 2008
  2. 01/10 Move split_cmdline() to alias.cMiklos Vajna, Jun 11, 2008
  3. 02/10 Move commit_list_count() to commit.cMiklos Vajna, Jun 11, 2008
  4. 03/10 Move parse-options's skip_prefix() to git-compat-util.hMiklos Vajna, Jun 11, 2008
  5. 04/10 Add new test to ensure git-merge handles pull.twohead and pull.octopusMiklos Vajna, Jun 11, 2008
  6. 05/10 parseopt: add a new PARSE_OPT_ARGV0_IS_AN_OPTION optionMiklos Vajna, Jun 11, 2008
  7. 06/10 Move read_cache_unmerged() to read-cache.cMiklos Vajna, Jun 11, 2008
  8. 07/10 git-fmt-merge-msg: make it usable from other builtinsMiklos Vajna, Jun 11, 2008
  9. 08/10 Introduce get_octopus_merge_bases() in commit.cMiklos Vajna, Jun 11, 2008
  10. 09/10 Introduce filter_independent() in commit.cMiklos Vajna, Jun 11, 2008
  11. 10/10 Build in mergeMiklos Vajna, Jun 11, 2008
  12. Introduce get_octopus_merge_bases() in commit.cMiklos Vajna, Jun 11, 2008
  13. Junio C HamanoJun 11, 2008
  14. Introduce get_octopus_merge_bases() in commit.cMiklos Vajna, Jun 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.