Re: BUG: CR marker ^M doesn't show up in '-' lines of diffs when the ending of the removed line is CR+LF

From: Frank Schäfer <fschaefer.oss@googlemail.com>
Date: Dec 5, 2018, 19:29 UTC
Message-ID: <de3bd8e1-cdd7-5fcf-0912-a216cc8cb3e9@googlemail.com>
In-Reply-To: <3572b619-0603-d16d-392c-4cc8e0bc4614@kdbg.org>

Am 02.12.18 um 22:22 schrieb Johannes Sixt:

Show 9 quoted lines

> Am 02.12.18 um 20:31 schrieb Frank Schäfer:
>> With other words:
>> "If CR comes immediately before a LF, do the following with *all* lines:
>> <RESET> after the CR if eol=lf but do not <RESET> after the CR if
>> eol=crlf."
>
> Why? It is the pager's duty to highlight CR, IMO. If it doesn't, but
> the user wants to see them, then they are using the wrong pager or the
> wrong pager settings.

AFAIU Junios explanation it's not the pagers fault.

Show 5 quoted lines

>
> As far as I am concerned, I do not have any of my files marked as
> eol=crlf, but I do *not* want to see ^M in the pager. I.e., having git
> insert <RESET> between CR and LF would do the wrong thing for me.
>

But doing the same thing in added lines is doing the right thing for you ? Or are you suggesting to fix the behavior of added lines instead ? In any case, inconsistent behavior is not what we want.

Regards, Frank