Re: [PATCH v8] var: support broken-down idents, signing key, multiple args, and -z

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 22, 2026, 14:57 UTC
Message-ID: <ddfd5232-b832-476c-8614-268f8e4bbe28@gmail.com>
In-Reply-To: <20260915220228.42819-1-andrewpleeter@gmail.com>

On 15/09/2026 23:02, Andrew Pleeter wrote:

Show 6 quoted lines

> Hi Junio,
> 
> Thank you for the guidance, and I sincerely apologize for the lack of
> communication. I had posted replies on the GitHub pull request and did
> not realize until now that GitGitGadget does not mirror PR comments back
> to the mailing list.

Ah, that explains the silence! I had a quick look at the PR comments but did not notice any response to my question about the use of GIT_SIGNING_KEY.

Show 14 quoted lines

> I certainly did not intend to be silent or ignore
> your reviews.
> 
> I completely agree with your feedback. Packing all of these features into
> a single commit makes the patch difficult to review and overcomplicates
> the history.
> 
> I will restructure the series for v9 into three separate patches as you
> suggested:
> 
> 1. Add the -z output mode to git var (-l and single-variable).
> 2. Teach git var to accept multiple variables (argc >= 2) with var=value
>     output.
> 3. Expose the broken-out identity components and GIT_SIGNING_KEY.

That sounds like a good direction

Thanks

Phillip

Show 5 quoted lines

> 
> I will send v9 shortly. Thank you again for your patience and direction.
> 
> Best regards,
> Andrew