Re: Git Test Coverage Report (Thurs. June 27)

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 28, 2019, 12:23 UTC
Message-ID: <ddf13a6b-42f4-57ae-49f1-8cc758b1dc4b@gmail.com>
In-Reply-To: <20190628064520.GB19777@sigill.intra.peff.net>

On 6/28/2019 2:45 AM, Jeff King wrote:

Show 13 quoted lines

> On Thu, Jun 27, 2019 at 01:35:17PM -0400, Derrick Stolee wrote:
> 
>>> t/helper/test-example-decorate.c
>>> 0ebbcf70 29) one = lookup_unknown_object(&one_oid);
>>> 0ebbcf70 30) two = lookup_unknown_object(&two_oid);
>>> 0ebbcf70 59) three = lookup_unknown_object(&three_oid);
>>
>> Peff: again interesting that these lines you refactored were not covered, especially
>> because they are part of a test helper. Perhaps the tests they were intended for are
>> now defunct?
> 
> They should be run by t9004 (and if I replace them with a `die`, they
> clearly are). Are you sure your coverage script is not mistaken?

It looks like I'm missing the 9000+ tests. The following line was in the script I adapted from another CI job:

	rm -f t/t9*.sh

This was probably because the job I adapted from needed to run quickly, but for this coverage report we should do the hard work of running whatever t9*.sh tests we can.

Sorry for the noise here, and thanks for checking!

-Stolee