Re: git 2.10.1 test regression in t3700-add.sh
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Oct 10, 2016, 19:14 UTC
- Message-ID
- <dddae1eb-347c-a285-0699-31f30eb924d8@kdbg.org>
- In-Reply-To
- <xmqq8ttwgkyo.fsf@gitster.mtv.corp.google.com>
Am 10.10.2016 um 19:41 schrieb Junio C Hamano:
> I also notice that the problematic test uses "chmod 755"; don't we > need POSIXPERM prerequisite on this test, too, I wonder?
Good point. Without POSIXPERM the test demonstrate that, since chmod 755 is basically a noop, the following add --chmod=-x does not leave an x bit in the index when there was none there in the first place. I think it does not hurt to keep the test even though it does not quite test the same thing as on POSIXPERM enabled systems.
-- Hannes