Re: [PATCH v2 2/2] parse-options: format argh like error messages

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 6, 2021, 12:05 UTC
Message-ID: <dd7d692a-0e78-0e98-6b1d-4157372d6674@gmail.com>
In-Reply-To: <c5f01b0eab1dd13d46ac344e362cd13e7bc365fc.1609933875.git.gitgitgadget@gmail.com>

On 1/6/2021 6:51 AM, Junio C Hamano via GitGitGadget wrote:

Show 12 quoted lines

> From: Junio C Hamano <gitster@pobox.com>
> 
> "Keep it homogeneous across the repository" is in general a
> guideline that can be used to converge to a good practice, but
> we can be a bit more prescriptive in this case.  Just like the
> messages we give die(_("...")) are formatted without the final
> full stop and without the initial capitalization, most of the
> argument help text are already formatted that way, and we want
> to encourage that as the house style.
> 
> Noticed-by: ZheNing Hu <adlternative@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

ZheNing,

It is certainly a common thing to pull patches from other contributors into your own series. However, you'll need to add your own sign-off at the end.

I also believe that the intention was that this patch would come before the other, so please swap the patches. Then, you can update the message in the other patch from

  According to the "Error Messages" section of
  Documentation/CodingGuidelines,

to

  According to the guidelines in parse-options.h,

Thanks, -Stolee