Re: [PATCH v2 00/10] sparse-checkout: make set subsume init
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Dec 7, 2021, 21:05 UTC
- Message-ID
- <dca78efd-1767-e07f-d33b-c8ecbd8bccac@gmail.com>
- In-Reply-To
- <pull.1151.v2.git.git.1638908410.gitgitgadget@gmail.com>
On 12/7/2021 3:20 PM, Elijah Newren via GitGitGadget wrote:
Show 24 quoted lines
> As described at [1], the split of init and set subcommands in > sparse-checkout causes multiple issues: > > * Poor performance (deleting all tracked files, then later restoring many > and maybe even most of them) > * Poor UI (multiple progress bars in wrappers that hide both commands under > 1 user-facing command) > * Loss of ignored files under directories the user wanted to keep > > This series fixes this bug by providing a single command to switch to a > sparse-checkout: set. It does so by making set able to do the combined work > of init and set. It keeps init as-is to give folks time to adapt, but marks > it as deprecated. It also makes reapply able to toggle cone/non-cone mode > and sparse-index/non-sparse-index mode. > > Changes since v1: > > * Inserted new patches 3 & 4 as additional preparatory cleanups > * Took the new mode-toggling work code in sparse_checkout_set from the > previous series and moved it into a new function, as a preparatory patch, > and made it usable by init/set/reapply > * Also updated reapply to allow mode-toggling > * Updated the documentation as per above > * Various other small items from review comments
I reread this series and the new patch organization is an improvement! I found this to be an easy read and have no suggestions for changes.
Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Thanks, -Stolee