git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] mingw: spawned processes need to inherit only standard handles

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 29, 2019, 22:19 UTC
Message-ID
<dbe065de-dac4-2dbf-0853-b7ea654136de@kdbg.org>
In-Reply-To
<nycvar.QRO.7.76.6.1911291036320.31080@tvgsbejvaqbjf.bet>
Am 29.11.19 um 14:52 schrieb Johannes Schindelin:
> On Thu, 28 Nov 2019, Johannes Sixt wrote:
> Out of curiosity: did you apply the patch on `master`, or on anything
> different?

I tested this on top of e1874e422f3a ("Merge branch 'sg/test-bool-env' into next", 2019-11-27), which is the commit before 4736894af6a1 ("Merge branch 'js/mingw-inherit-only-std-handles' into next", 2019-11-27). I merged your branch up to 9a780a384de2 ("mingw: spawned processes need to inherit only standard handles", 2019-11-22) (plus one of my own patches with Makefile adjustments).

> I wonder how you get that ERANGE when I get an ENOENT (and so do all the
> CI/PR builds that did not catch this).
I'll dig into this now.
-- Hannes
Previous: Johannes SchindelinNext: Johannes Sixt
Message 9 of 13 in “On Windows, limit which file handles are inherited by spawned child processes”
  1. 0/4 On Windows, limit which file handles are inherited by spawned child processesJohannes Schindelin via GitGitGadget, Nov 22, 2019
  2. 2/4 mingw: work around incorrect standard handlesJohannes Schindelin via GitGitGadget, Nov 22, 2019
  3. 1/4 mingw: demonstrate that all file handles are inherited by child processesJohannes Schindelin via GitGitGadget, Nov 22, 2019
  4. 4/4 mingw: restrict file handle inheritance only on Windows 7 and laterJohannes Schindelin via GitGitGadget, Nov 22, 2019
  5. 3/4 mingw: spawned processes need to inherit only standard handlesJohannes Schindelin via GitGitGadget, Nov 22, 2019
  6. Johannes SixtNov 28, 2019
  7. Johannes SchindelinNov 29, 2019
  8. Johannes SchindelinNov 29, 2019
  9. Johannes SixtNov 29, 2019
  10. Johannes SixtNov 29, 2019
  11. Johannes SchindelinNov 30, 2019
  12. Junio C HamanoNov 25, 2019
  13. Johannes SchindelinNov 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.