tag format and tests
- From
- David Glesser <glesserd@ensimag.fr>
- Date
- May 30, 2011, 14:12 UTC
- Message-ID
- <db6ec478a7cb9b963d90651f5315ffec@ensimag.fr>
Hello,
We are currently coding a minimal git client using libgit2. We use git tests to test our git client. We have an error caused by the tag format used by libgit2. The test t1006-cat-file.sh report many errors, the first one is: not ok - 23 Size of tag is correct This error comes from libgit2 and how it writes the timestamp, see below:
$ cat tag && echo object 5e1c309dae7f45e0f39b1bf3ac3cd9db12e7d689 type blob tag hellotag tagger SpongeBob <spongebob.square@crusty-crabs.com> 0000000000 +0000
cheeseburger $ git mktag < tag 7eade44ddd1b9ee24a44e0b2dde2561efea7f7d6 $ echo 7eade44ddd1b9ee24a44e0b2dde2561efea7f7d6 | git cat-file --batch 7eade44ddd1b9ee24a44e0b2dde2561efea7f7d6 tag 154 object 5e1c309dae7f45e0f39b1bf3ac3cd9db12e7d689 type blob tag hellotag tagger SpongeBob <spongebob.square@crusty-crabs.com> 0000000000 +0000
cheeseburger
And now using libgit2 :
$ git2 mktag < tag 49bc784cd2071c97a14841b3eab1181dd1c8fbcd $ echo 49bc784cd2071c97a14841b3eab1181dd1c8fbcd | git cat-file --batch 49bc784cd2071c97a14841b3eab1181dd1c8fbcd tag 145 object 5e1c309dae7f45e0f39b1bf3ac3cd9db12e7d689 type blob tag hellotag tagger SpongeBob <spongebob.square@crusty-crabs.com> 0 +0000
cheeseburger
Both formats are accepted by git. It's reasonable to say that the test is wrong because it doesn't fit exactly with the format ?
David G.