git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] diff: demonstrate a bug with --patience and --ignore-space-at-eol

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 9, 2016, 07:23 UTC
Message-ID
<db5aa5d1f22a22901eb3dd57132e027f462852c5.1468048754.git.johannes.schindelin@gmx.de>
In-Reply-To
<cover.1468048754.git.johannes.schindelin@gmx.de>

When a single character is added to a line, the combination of these two options results in an empty diff.

This bug was noticed and reported by Naja Melan.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t4033-diff-patience.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/t/t4033-diff-patience.sh b/t/t4033-diff-patience.sh
index 3c9932e..5f0d0b1 100755
--- a/t/t4033-diff-patience.sh
+++ b/t/t4033-diff-patience.sh
@@ -5,6 +5,14 @@ test_description='patience diff algorithm'
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-diff-alternative.sh
 
+test_expect_failure '--ignore-space-at-eol with a single appended character' '
+	printf "a\nb\nc\n" >pre &&
+	printf "a\nbX\nc\n" >post &&
+	test_must_fail git diff --no-index \
+		--patience --ignore-space-at-eol pre post >diff &&
+	grep "^+.*X" diff
+'
+
 test_diff_frobnitz "patience"
 
 test_diff_unique "patience"
-- 
2.9.0.278.g1caae67
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 2 of 5 in “Fix xdiff's --ignore-space-at-eol handling”
  1. 0/2 Fix xdiff's --ignore-space-at-eol handlingJohannes Schindelin, Jul 9, 2016
  2. 1/2 diff: demonstrate a bug with --patience and --ignore-space-at-eolJohannes Schindelin, Jul 9, 2016
  3. 2/2 diff: fix a double off-by-one with --ignore-space-at-eolJohannes Schindelin, Jul 9, 2016
  4. Naja MelanJul 9, 2016
  5. Junio C HamanoJul 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.